Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1739 +/- ##
==========================================
+ Coverage 96.46% 96.48% +0.01%
==========================================
Files 49 49
Lines 3791 3810 +19
==========================================
+ Hits 3657 3676 +19
Misses 134 134 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Alexj9837
force-pushed
the
register-child-devices-on-top
branch
from
November 3, 2026 08:35
b4975f8 to
e7797e3
Compare
Alexj9837
force-pushed
the
register-child-devices-on-top
branch
from
November 3, 2026 08:36
e7797e3 to
396a673
Compare
Alexj9837
force-pushed
the
register-child-devices-on-top
branch
from
November 3, 2026 09:10
9fd0086 to
8ee7db7
Compare
tpoliaw
reviewed
Nov 4, 2026
tpoliaw
left a comment
tpoliaw
left a comment
Contributor
There was a problem hiding this comment.
Mostly looks ok, I'm mainly unsure of the required behaviour around handling duplicates.
… on feedback from Peter Drop the identity replacement test as other tests already cover it
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1724
Registering an ophyd-async device now also registers its children, including signals, under their own names at any depth (
stagealso givesstage-x,stage-x-velocityetc). Dotted access still works. Ophyd v1 devices are left alone.Name clashes:
user_readback, which ophyd-async gives the motor's name. It's still reachable asmotor.user_readback/devicesreports each device under its registered name, so a motor registered with an override name doesn't appear twice alongside its readbackThings to note:
/devicesand the plan schemas get a lot bigger (adsim goes from 2 to 117 devices), and low level signals like setpoints now show up as plan argument options.